Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto retry bug #1639

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: auto retry bug #1639

merged 3 commits into from
Oct 24, 2024

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Oct 22, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

When the max auto retry value is null, form was not validating the max auto retry value field
Made the required code changes, now its working

image

Motivation and Context

How did you test it?

Go to payment settings
enable auto retry toggle
try clicking update
update button shows error tooltip and is disabled

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Oct 22, 2024
@gitanjli525 gitanjli525 self-assigned this Oct 22, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner October 22, 2024 11:38
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@gitanjli525 gitanjli525 changed the title fix: handling if max retry calue is null, validate form should detect… fix: handling if max retry value is null, validate form should detect… Oct 22, 2024
@gitanjli525 gitanjli525 changed the title fix: handling if max retry value is null, validate form should detect… fix: auto retry bug Oct 22, 2024
@JeevaRamu0104 JeevaRamu0104 added S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 23, 2024
@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Oct 24, 2024
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 46f4de6 Oct 24, 2024
5 of 6 checks passed
@prajwalnl0 prajwalnl0 deleted the max-auto-retry-null-handling branch October 24, 2024 06:48
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core Status: issues related to core labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gitanjli525 @Riddhiagrawal001 @JeevaRamu0104 @prajwalnl0